feat: add timesfm-3 - #373
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The docs examples index introduces a link to tafsut.ipynb, but that notebook file is not present, creating a broken documentation link.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR adds support for the TimesFM 3.0 checkpoint (google/timesfm-3.0-pytorch) by bumping foundationforecast (and related lockfile deps), extending TimesFM tests for the new backend, and updating documentation/changelog to reflect the new model availability and licensing note.
Changes:
- Bump
foundationforecastto>=0.1.3and update the lockfile to pull in the updated TimesFM backend. - Extend TimesFM unit tests to cover the
_TimesFMV3loading path and routing for the 3.0 repo id. - Add docs/nav entries and a v0.0.32 changelog entry for TimesFM 3.0 (plus the TimesFM family notebook link).
File summaries
| File | Description |
|---|---|
| uv.lock | Updates resolved dependency versions for foundationforecast and TimesFM-related packages. |
| tests/models/foundation/test_timesfm.py | Adds _TimesFMV3 coverage and a routing test for the 3.0 repo id. |
| tests/models/conftest.py | Adds google/timesfm-3.0-pytorch to the shared model test matrix. |
| pyproject.toml | Bumps foundationforecast minimum version and the project version to 0.0.32. |
| mkdocs.yml | Adds the TimesFM family notebook and v0.0.32 changelog to the docs nav. |
| docs/model-hub.md | Updates TimesFM entry to include 3.0 license link. |
| docs/examples/index.md | Adds TimesFM family notebook entry (and a Tafsut entry). |
| docs/changelogs/v0.0.32.md | New changelog entry documenting TimesFM 3.0 support and license note. |
| docs/changelogs/index.md | Adds v0.0.32 to the changelog index. |
Review details
- Files reviewed: 8/10 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
🟡 Changes recommended
Adding TimesFM 3.0 to the shared parametrized model test matrix may create avoidable CI runtime/flakiness risk and should be gated or explicitly classified as integration/slow.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 8/10 changed files
- Comments generated: 1
- Review effort level: Lite
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
this pr add support for timesfm-3 trough foundationforecast